[PATCH 3/6] drm/radeon: add some HDMI comments

Alex Deucher alexdeucher at gmail.com
Sun Apr 14 14:36:34 PDT 2013


On Sun, Apr 14, 2013 at 1:58 PM, Rafał Miłecki <zajec5 at gmail.com> wrote:
> 2013/4/14 Alex Deucher <alexdeucher at gmail.com>:
>>> +               /*
>>> +                * According to the commens above we should use !DCE41 || DCE5,
>>> +                * condition, however there isn't any DCE5 that is DCE41, so
>>> +                * DCE5 check is not needed.
>>> +                */
>>
>> It would probably be more obvious to just loop over rdev->num_crtc
>> since the number of hdmi blocks matches the number of crtcs.
>
> Not really.
>
> 1) CHIP_CAICOS
> It has 4 CRTCs but is DCE5, so has 6 AFMTs
>
> 2) CHIP_CEDAR
> It has 4 CRTCs but is DCE4, so also has 6 AFMTs
>

Oh, right.  I forgot about the 4 crtc parts.

Alex


More information about the dri-devel mailing list