[PATCH] drm/i915: no lvds quirk for hp t5740

[Ben Mesman (Bossers & Cnossen BV)]

> -----Oorspronkelijk bericht-----
> Van: 'Chris Wilson' [mailto:chris at chris-wilson.co.uk]
> Verzonden: maandag 15 april 2013 11:59
> Aan: Ben Mesman (Bossers & Cnossen BV)
> CC: Daniel Vetter; dri-devel at lists.freedesktop.org
> Onderwerp: Re: [PATCH] drm/i915: no lvds quirk for hp t5740
> 
> On Mon, Apr 15, 2013 at 09:54:56AM +0000, Ben Mesman (Bossers &
> Cnossen BV) wrote:
> > > -----Oorspronkelijk bericht-----
> > > Van: 'Chris Wilson' [mailto:chris at chris-wilson.co.uk]
> > > Verzonden: maandag 15 april 2013 11:39
> > > Aan: Ben Mesman (Bossers & Cnossen BV)
> > > CC: Daniel Vetter; dri-devel at lists.freedesktop.org
> > > Onderwerp: Re: [PATCH] drm/i915: no lvds quirk for hp t5740
> > >
> > > On Mon, Apr 15, 2013 at 06:39:15AM +0000, Ben Mesman (Bossers &
> > > Cnossen BV) wrote:
> > > > Op vrijdag 12 april 2013 14:47 schreef Chris Wilson:
> > > > > On Fri, Apr 12, 2013 at 02:24:43PM +0200, Ben Mesman wrote:
> > > > > > Last year, a patch was made for the "HP t5740e Thin Client"
> > > > > > (see
> > > > > > http://lists.freedesktop.org/archives/dri-devel/2012-
> > > May/023245.html).
> > > > > > This device reports an lvds panel, but does not really have one.
> > > > > >
> > > > > > The predecessor of this device is the "hp t5740", which also
> > > > > > does not have an lvds panel. This patch will add the same
> > > > > > quirk for this
> > > device.
> > > > > >
> > > > > > Signed-off-by: Ben Mesman <ben at bnc.nl>
> > > > > > ---
> > > > > >  drivers/gpu/drm/i915/intel_lvds.c |    8 ++++++++
> > > > > >  1 file changed, 8 insertions(+)
> > > > > >
> > > > > > diff --git a/drivers/gpu/drm/i915/intel_lvds.c
> > > > > > b/drivers/gpu/drm/i915/intel_lvds.c
> > > > > > index ca2d903..8a56d9b 100644
> > > > > > --- a/drivers/gpu/drm/i915/intel_lvds.c
> > > > > > +++ b/drivers/gpu/drm/i915/intel_lvds.c
> > > > > > @@ -816,6 +816,14 @@ static const struct dmi_system_id
> > > > > > intel_no_lvds[] =
> > > > > {
> > > > > >  	},
> > > > > >  	{
> > > > > >  		.callback = intel_no_lvds_dmi_callback,
> > > > > > +		.ident = "Hewlett-Packard hp t5740",
> > > > > > +		.matches = {
> > > > > > +			DMI_MATCH(DMI_BOARD_VENDOR,
> "Hewlett-
> > > > > Packard"),
> > > > > > +			DMI_MATCH(DMI_PRODUCT_NAME, "hp
> t5740"),
> > > > > > +		},
> > > > > > +	},
> > > > >
> > > > > One thing to note is that the dmi matching routine uses strstr
> > > > > (as opposed to
> > > > > dmi_match() which uses strcmp!) so this rule should encompass
> > > > > the following rule for its offspring.
> > > >
> > > > I am sorry, I don't know what you are asking here. Is there
> > > > something
> > > wrong with this patch?
> > >
> > > I meant you could adjust the t5470e rule to also catch t5470:
> >
> > Except that strstr is (probably?) not case-insensitive.
> 
> Whoops, then drop the "hp" prefix as the board vendor is already specified.

Ok, I reworked the patch and will test this on a t5740 and a t5740e (we have both). If it tests ok, I'll re-submit the patch tomorrow.

-- 
Regards,
Ben Mesman.