[PATCH Resend] drm/exynos: Select VIDEOMODE_HELPERS for FIMD

Inki Dae inki.dae at samsung.com
Thu Apr 25 21:41:05 PDT 2013



> -----Original Message-----
> From: Sachin Kamat [mailto:sachin.kamat at linaro.org]
> Sent: Thursday, April 25, 2013 8:36 PM
> To: dri-devel at lists.freedesktop.org
> Cc: inki.dae at samsung.com; jy0922.shim at samsung.com; sachin.kamat at linaro.org
> Subject: [PATCH Resend] drm/exynos: Select VIDEOMODE_HELPERS for FIMD
> 
> FIMD also requires video mode helper APIs.
> Without this patch we get the following build error:
> drivers/gpu/drm/exynos/exynos_drm_fimd.c:895: undefined reference to
> `of_get_fb_videomode'
> make: *** [vmlinux] Error 1
> 
> Signed-off-by: Sachin Kamat <sachin.kamat at linaro.org>
> ---
>  drivers/gpu/drm/exynos/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/exynos/Kconfig
> b/drivers/gpu/drm/exynos/Kconfig
> index 406f32a..8edca41 100644
> --- a/drivers/gpu/drm/exynos/Kconfig
> +++ b/drivers/gpu/drm/exynos/Kconfig
> @@ -27,6 +27,7 @@ config DRM_EXYNOS_FIMD
>  	depends on OF && DRM_EXYNOS && !FB_S3C && !ARCH_MULTIPLATFORM
>  	select OF_VIDEOMODE

The above line isn't needed anymore. I just removed and merged it. And I
can't find this patch on dri-devel mailing list. Maybe you didn't still
subscribe dri-devel mailing list.

Thanks,
Inki Dae

>  	select FB_MODE_HELPERS
> +	select VIDEOMODE_HELPERS
>  	help
>  	  Choose this option if you want to use Exynos FIMD for DRM.
> 
> --
> 1.7.9.5



More information about the dri-devel mailing list