[PATCH 4/4] ARM: EXYNOS: remove parent device for hdmiphy clock
Sean Paul
seanpaul at chromium.org
Mon Apr 29 10:04:41 PDT 2013
On Mon, Apr 29, 2013 at 10:50 AM, Rahul Sharma <rahul.sharma at samsung.com> wrote:
> Hdmiphy clock flows from hdmiphy hw to hdmi ip and mixer. It is commonly
> accessed among hdmi and hdmiphy driver. During power cycle, each of these
> driver decrements the ref-count and ensures that last user disables the
> clock. Setting parrent device to none ensure that both the drivers gets
> access to the clock.
>
This seems like the wrong solution. I think you should be trying to
isolate its usage to one driver, instead of removing devname.
Sean
> Signed-off-by: Rahul Sharma <rahul.sharma at samsung.com>
> ---
> arch/arm/mach-exynos/clock-exynos4.c | 1 -
> arch/arm/mach-exynos/clock-exynos5.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/clock-exynos4.c b/arch/arm/mach-exynos/clock-exynos4.c
> index 8a8468d..a43afcd 100644
> --- a/arch/arm/mach-exynos/clock-exynos4.c
> +++ b/arch/arm/mach-exynos/clock-exynos4.c
> @@ -562,7 +562,6 @@ static struct clk exynos4_init_clocks_off[] = {
> .ctrlbit = (1 << 3),
> }, {
> .name = "hdmiphy",
> - .devname = "exynos4-hdmi",
> .enable = exynos4_clk_hdmiphy_ctrl,
> .ctrlbit = (1 << 0),
> }, {
> diff --git a/arch/arm/mach-exynos/clock-exynos5.c b/arch/arm/mach-exynos/clock-exynos5.c
> index b0ea31f..4f39027 100644
> --- a/arch/arm/mach-exynos/clock-exynos5.c
> +++ b/arch/arm/mach-exynos/clock-exynos5.c
> @@ -690,7 +690,6 @@ static struct clk exynos5_init_clocks_off[] = {
> .ctrlbit = (1 << 6),
> }, {
> .name = "hdmiphy",
> - .devname = "exynos5-hdmi",
> .enable = exynos5_clk_hdmiphy_ctrl,
> .ctrlbit = (1 << 0),
> }, {
> --
> 1.7.10.4
>
More information about the dri-devel
mailing list