[Intel-gfx] [PATCH 2/3] drm/i915: unpin backing storage in dmabuf_unmap

Chris Wilson chris at chris-wilson.co.uk
Wed Aug 7 02:29:59 PDT 2013


On Wed, Aug 07, 2013 at 11:15:07AM +0200, Daniel Vetter wrote:
> This fixes a WARN in i915_gem_free_object when the
> obj->pages_pin_count isn't 0.
> 
> Reported-by: Maarten Lankhorst <maarten.lankhorst at canonical.com>
> Cc: Maarten Lankhorst <maarten.lankhorst at canonical.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Papers over the WARN with iffy locking. Not all callers hold
struct_mutex, right? Worse some do, some don't...

What's the long term plan here?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the dri-devel mailing list