[PATCH 2/2] drm/i915: no interruptible locking for dma_buf->map

Chris Wilson chris at chris-wilson.co.uk
Wed Aug 7 03:30:01 PDT 2013


On Wed, Aug 07, 2013 at 12:09:33PM +0200, Daniel Vetter wrote:
> It's unclear whether ->map is allowed to fail with -EINTR, but
> looking at current callers it's pretty clear that they don't
> expect this to happen. So use a blocking mutex_lock call. Since
> we don't wait for the gpu in our ->map callback the lack of the
> gpu hang checks doesn't matter.
> 
> Furthermore the goal is to eventually have per dma-buf locking done
> by callers with ww mutexes, so this will then be removed.
> 
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Ugh, who can't handle EINTR here but can handle all the other errors?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the dri-devel mailing list