Build break due to 28ec711 "drm/agp: move AGP cleanup paths to drm_agpsupport.c"

[David Herrmann]

Hi

On Thu, Aug 8, 2013 at 8:00 PM, Stephen Warren <swarren at wwwdotorg.org> wrote:
> In next-20130808, building tegra_defconfig for ARM yields:
>
>> drivers/built-in.o: In function `drm_lastclose':
>> /home/swarren/shared/git_wa/kernel/kernel.git/drivers/gpu/drm/drm_drv.c:198: undefined reference to `drm_agp_clear'
>
> That's because drm_agp_clear() is called unconditionally, yet is only
> conditionally built into drm_agpsupport.c (#if __OS_HAS_AGP).
>
> Should the call from drm_drv.c be conditional, or should there be a
> dummy static inline replacement in include/drm/drmP.h for when AGP
> support isn't available?

Sorry, I missed testing with AGP=n and the code I fixed depended on
dead-code-elimination to link correctly. I overlooked that. There is a
patch pending on dri-devel:
http://lists.freedesktop.org/archives/dri-devel/2013-August/043077.html

Regards
David