[PATCH 5/5] ARM: tegra: Add hdmi to Tegra114 Dalmore device tree

[Thierry Reding]

On Wed, Aug 28, 2013 at 01:40:59PM +0300, Mikko Perttunen wrote:
> Add hdmi node to Dalmore device tree to supply Dalmore-specific

s/hdmi/HDMI/

> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
[...]
> +	host1x {
> +		hdmi {
> +			status = "okay";
> +
> +			vdd-supply = <&vdd_hdmi_reg>;
> +			pll-supply = <&palmas_smps3_reg>;
> +			nvidia,ddc-i2c-bus = <&hdmi_ddc>;

I prefer to use a blank line to separate "standard" from
"vendor-specific" properties.

> +			nvidia,hpd-gpio = <&gpio TEGRA_GPIO(N, 7) GPIO_ACTIVE_HIGH>;

Other .dts files split this so it doesn't exceed 80 characters. I'm not
sure how useful that is as a general rule for DT source files, though.

>  	i2c at 7000d000 {
>  		status = "okay";
>  		clock-frequency = <400000>;
> @@ -1169,6 +1184,8 @@
>  			regulator-min-microvolt = <5000000>;
>  			regulator-max-microvolt = <5000000>;
>  			enable-active-high;
> +			regulator-always-on;
> +			regulator-boot-on;

This warrants at least a mention in the commit message.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130828/d7c60c76/attachment.pgp>