[PATCH] drm: shmob_drm: Check clk_prepare_enable() return value

[Thierry Reding]

On Mon, Dec 02, 2013 at 01:52:20AM +0100, Laurent Pinchart wrote:
[...]
> diff --git a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c
[...]
> @@ -170,7 +178,9 @@ static void shmob_drm_crtc_start(struct shmob_drm_crtc *scrtc)
>  		return;
>  
>  	/* Enable clocks before accessing the hardware. */
> -	shmob_drm_clk_on(sdev);
> +	ret = shmob_drm_clk_on(sdev);
> +	if (ret < 0)
> +		return;

Perhaps this should be printing an error or using WARN_ON()? Otherwise
it might be very difficult to diagnose what's going wrong.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20131203/06d5c1b0/attachment.pgp>