[PATCH 06/50] drm/shmob: call drm_put_dev directly from ->remove hook

Laurent Pinchart laurent.pinchart at ideasonboard.com
Wed Dec 11 04:21:51 PST 2013


Hi Daniel,

Thank you for the patch.

On Wednesday 11 December 2013 11:34:27 Daniel Vetter wrote:
> We need to chase one pointer here.
> 
> Cc: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Acked-by: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>

> ---
>  drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c
> b/drivers/gpu/drm/shmobile/shmob_drm_drv.c index 015551866b4a..c839c9c89efb
> 100644
> --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c
> +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c
> @@ -336,7 +336,9 @@ static int shmob_drm_probe(struct platform_device *pdev)
> 
>  static int shmob_drm_remove(struct platform_device *pdev)
>  {
> -	drm_platform_exit(&shmob_drm_driver, pdev);
> +	struct shmob_drm_device *sdev = platform_get_drvdata(pdev);
> +
> +	drm_put_dev(sdev->ddev);
> 
>  	return 0;
>  }
-- 
Regards,

Laurent Pinchart



More information about the dri-devel mailing list