[PATCH 28/50] drm: Remove DRM_WAIT_ON from all drivers

Dave Airlie airlied at gmail.com
Tue Dec 17 17:39:27 PST 2013


On Wed, Dec 11, 2013 at 8:34 PM, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> Since this is all old ums stuff (including the one in the radeon
> driver) I've just tried to perfectly replicate the existing semantics.
>
> Reinventing wait queue code with semantics that differ from all the
> standard linux wait functions is just hairy, so now we can get rid of
> this and so make sure it'll never again be used.
>
> Oh and: via futexes ... *shudder*

This one worries me, I've had numerous attempts to rip this out in the
past and they always changed semantics on some devices and broke
stuff.

The sneaky timeout is essential for a lot of the hardware

http://marc.info/?l=dri-devel&m=111383274225047&w=1

So I think I'd like a few more people to review this one before I go
near it again :-)

Dave.


More information about the dri-devel mailing list