[PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

[Sachin Kamat]

On 1 February 2013 18:28, Inki Dae <daeinki at gmail.com> wrote:
>
>
>
>
> 2013. 2. 1. 오후 8:52 Inki Dae <inki.dae at samsung.com> 작성:
>
>>
>>
>>> -----Original Message-----
>>> From: linux-media-owner at vger.kernel.org [mailto:linux-media-
>>> owner at vger.kernel.org] On Behalf Of Sachin Kamat
>>> Sent: Friday, February 01, 2013 8:40 PM
>>> To: Inki Dae
>>> Cc: Sylwester Nawrocki; Kukjin Kim; Sylwester Nawrocki; linux-
>>> media at vger.kernel.org; dri-devel at lists.freedesktop.org; devicetree-
>>> discuss at lists.ozlabs.org; patches at linaro.org
>>> Subject: Re: [PATCH 2/2] drm/exynos: Add device tree based discovery
>>> support for G2D
>>>
>>> On 1 February 2013 17:02, Inki Dae <inki.dae at samsung.com> wrote:
>>>>
>>>> How about using like below?
>>>>        Compatible = ""samsung,exynos4x12-fimg-2d" /* for Exynos4212,
>>>> Exynos4412  */
>>>> It looks odd to use "samsung,exynos4212-fimg-2d" saying that this ip is
>>> for
>>>> exynos4212 and exynos4412.
>>>
>>> AFAIK, compatible strings are not supposed to have any wildcard
>> characters.
>>> Compatible string should suggest the first SoC that contained this IP.
>>> Hence IMO 4212 is OK.
>>>
>
> Oops, one more thing. AFAIK Exynos4210 also has fimg-2d ip. In this case, we should use "samsung,exynos4210-fimg-2d" as comparible string and add it to exynos4210.dtsi?

Exynos4210 has same g2d IP (v3.0) as C110 or V210; so the same
comptible string will be used for this one too.

> And please check if exynos4212 and 4412 SoCs have same fimg-2d ip. If it's different, we might need to add ip version property or compatible string to each dtsi file to identify the ip version.

AFAIK, they both have the same IP (v4.1).

>
> Sorry but give me your opinions.
>
> Thanks,
> Inki Dae
>
>
>>
>> Got it. Please post it again.
>>
>>>
>>> --
>>> With warm regards,
>>> Sachin
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>>> the body of a message to majordomo at vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel



-- 
With warm regards,
Sachin