[PATCH 07/16] drm/fb-helper: unexport drm_fb_helper_single_fb_probe

Rob Clark robdclark at gmail.com
Mon Feb 11 14:14:29 PST 2013


On Thu, Jan 24, 2013 at 10:20 AM, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> Not called by anyone, and really, shouldn't be. Drivers are supposed
> either drm_fb_helper_initial_config or drm_fb_helper_hotplug_event.
> Originally this was done differently, but is now consolidated in the
> helper functions and no longer done by drivers directly.
>
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Reviewed-by: Rob Clark <robdclark at gmail.com>

> ---
>  drivers/gpu/drm/drm_fb_helper.c |    5 ++---
>  include/drm/drm_fb_helper.h     |    3 ---
>  2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index 4549512..2377fef 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -754,8 +754,8 @@ int drm_fb_helper_pan_display(struct fb_var_screeninfo *var,
>  }
>  EXPORT_SYMBOL(drm_fb_helper_pan_display);
>
> -int drm_fb_helper_single_fb_probe(struct drm_fb_helper *fb_helper,
> -                                 int preferred_bpp)
> +static int drm_fb_helper_single_fb_probe(struct drm_fb_helper *fb_helper,
> +                                        int preferred_bpp)
>  {
>         int new_fb = 0;
>         int crtc_count = 0;
> @@ -870,7 +870,6 @@ int drm_fb_helper_single_fb_probe(struct drm_fb_helper *fb_helper,
>
>         return 0;
>  }
> -EXPORT_SYMBOL(drm_fb_helper_single_fb_probe);
>
>  void drm_fb_helper_fill_fix(struct fb_info *info, uint32_t pitch,
>                             uint32_t depth)
> diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
> index 4e989dc..62f8848 100644
> --- a/include/drm/drm_fb_helper.h
> +++ b/include/drm/drm_fb_helper.h
> @@ -82,9 +82,6 @@ struct drm_fb_helper {
>         bool delayed_hotplug;
>  };
>
> -int drm_fb_helper_single_fb_probe(struct drm_fb_helper *helper,
> -                                 int preferred_bpp);
> -
>  int drm_fb_helper_init(struct drm_device *dev,
>                        struct drm_fb_helper *helper, int crtc_count,
>                        int max_conn);
> --
> 1.7.10.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel


More information about the dri-devel mailing list