[PATCH 0/8] Enable eDP PSR functionality at HSW - v3

Rodrigo Vivi rodrigo.vivi at gmail.com
Mon Feb 25 14:55:14 PST 2013


PSR is an eDP feature that allows power saving even with static image at eDP screen.

v3: Accepted many suggestions that I received at v2 review, fixing, cleaning and improving the code.

v2: Main differences in this v2:
- Created vbt struct to get i915 dev_priv more organized and to avoid adding more stuff into it.
- migrated hsw macros to use transcoder instead of pipes than I could address eDP
- remove patch that was only adding edp psr registers and added them on demand

v1:
Shobit Kumar has implemented this patch series some time ago, but had no eDP panel with PSR capability to test them.

I could test and verify that this series fully identify PSR capability and enables it at HSW.
I also verified that it saves from 0.5-1W but only when in blank screen. It seems it is not really entering in sleeping mode with static image at eDP screen yet.

Please accept this series as the first part of PSR enabling while we continue working to improve its functionality.

Rodrigo Vivi (5):
  drm/i915: Organize VBT stuff inside drm_i915_private
  drm/i915: Use cpu_transcoder for HSW_TVIDEO_DIP_* instead of pipe
  drm/i915: Enable/Disable PSR
  drm/i915: Added debugfs support for PSR Status
  drm/i915: Hook PSR functionality

Shobhit Kumar (3):
  drm/i915: Added SDP and VSC structures for handling PSR for eDP
  drm/i915: Read the EDP DPCD and PSR Capability
  drm/i915: VBT Parsing for the PSR Feature Block for HSW

 drivers/gpu/drm/i915/i915_debugfs.c  |  92 ++++++++++++++++
 drivers/gpu/drm/i915/i915_dma.c      |   8 +-
 drivers/gpu/drm/i915/i915_drv.h      |  63 ++++++-----
 drivers/gpu/drm/i915/i915_reg.h      |  82 ++++++++++++--
 drivers/gpu/drm/i915/intel_bios.c    | 126 +++++++++++++--------
 drivers/gpu/drm/i915/intel_bios.h    |  20 +++-
 drivers/gpu/drm/i915/intel_crt.c     |   4 +-
 drivers/gpu/drm/i915/intel_ddi.c     |   2 +
 drivers/gpu/drm/i915/intel_display.c |  16 +--
 drivers/gpu/drm/i915/intel_dp.c      | 208 ++++++++++++++++++++++++++++++++++-
 drivers/gpu/drm/i915/intel_drv.h     |   4 +
 drivers/gpu/drm/i915/intel_hdmi.c    |  13 ++-
 drivers/gpu/drm/i915/intel_lvds.c    |  20 ++--
 drivers/gpu/drm/i915/intel_sdvo.c    |   6 +-
 drivers/gpu/drm/i915/intel_tv.c      |   8 +-
 include/drm/drm_dp_helper.h          |  22 ++++
 16 files changed, 569 insertions(+), 125 deletions(-)

-- 
1.8.1.2



More information about the dri-devel mailing list