[PATCH] drm/mgag200: Cleanup: Remove pointless call to drm_fb_get_bpp_depth

[Paul Menzel]

Dear Christopher,


thank you for your patches. Not sure if you should CC some maintainer
(or if you did already).


Am Dienstag, den 26.02.2013, 10:53 -0500 schrieb Christopher Harvey:

1. I guess you can remove Cleanup from the commit summary.
2. Why is it »pointless«? I guess a compiler warning that bpp is unused?
Please paste it into the commit message then. As otherwise this cannot
be judged from just looking at the diff below.

> Signed-off-by: Christopher Harvey <charvey at matrox.com>
> ---
>  drivers/gpu/drm/mgag200/mgag200_fb.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mgag200/mgag200_fb.c b/drivers/gpu/drm/mgag200/mgag200_fb.c
> index 2f48648..d46bd2c 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_fb.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_fb.c
> @@ -104,12 +104,9 @@ static int mgag200fb_create_object(struct mga_fbdev *afbdev,
>  				   struct drm_gem_object **gobj_p)
>  {
>  	struct drm_device *dev = afbdev->helper.dev;
> -	u32 bpp, depth;
>  	u32 size;
>  	struct drm_gem_object *gobj;
> -
>  	int ret = 0;
> -	drm_fb_get_bpp_depth(mode_cmd->pixel_format, &depth, &bpp);
>  
>  	size = mode_cmd->pitches[0] * mode_cmd->height;
>  	ret = mgag200_gem_create(dev, size, true, &gobj);


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130227/a11a6265/attachment.pgp>