[PATCH 1/1] drm: Fix comment about drm_exit which has been replaced by drm_platform_exit in 2.6.39

Philippe De Swert philippe.deswert at jollamobile.com
Thu Jan 10 09:24:49 PST 2013


Hello Dave,

On 10/01/13 02:57, Dave Airlie wrote:
>>   /**
>> - * Called via drm_exit() at module unload time or when pci device is
>> + * Called via drm_platform_exit() at module unload time or when pci device is
>>    * unplugged.
>
> Not really correct, its called from drm_pci_exit, drm_usb_exit and
> drm_platform_exit now.

You are totally right, just changing that bit of the comment did not fix 
it completely. drm_pci/usb_exit will be called on unload and disconnect 
of the device (which is actually quite rare on PCI). And the
comment does not even mention usb.

Would you like a new patch with a completely new comment? Should it be 
removed completely? Or will you fix it yourself when you come around to it?

Thanks,

Philippe



More information about the dri-devel mailing list