[PATCH 12/35] drm/gma500: use drm_modeset_lock_all

Alan Cox alan at lxorguk.ukuu.org.uk
Thu Jan 10 14:36:33 PST 2013


On Thu, 10 Jan 2013 21:47:53 +0100
Daniel Vetter <daniel.vetter at ffwll.ch> wrote:

> Only two places:
> - suspend/resume
> - Some really strange mode validation tool with too much funny-lucking
>   hand-rolled conversion code.
> - The recently-added lastclose fbdev restore code.
> 
> Better safe than sorry, so convert both places to keep the locking
> semantics as much as possible.

Seems fine. The last close behaviour really ought to be in the core DRM
code. Telling people to discover magic incantations with sysrq is a total
fail, especially on tablets and other devices that don't *have* a sysrq
key.

Alan


More information about the dri-devel mailing list