[PATCH 08/35] drm/<drivers>: Unified handling of unimplemented fb->create_handle

Thierry Reding thierry.reding at avionic-design.de
Fri Jan 18 07:00:50 PST 2013


On Thu, Jan 10, 2013 at 09:47:49PM +0100, Daniel Vetter wrote:
[...]
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index 8d665fa..a9abf49 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -2384,7 +2384,10 @@ int drm_mode_getfb(struct drm_device *dev,
>  	r->depth = fb->depth;
>  	r->bpp = fb->bits_per_pixel;
>  	r->pitch = fb->pitches[0];
> -	fb->funcs->create_handle(fb, file_priv, &r->handle);
> +	if (fb->funcs->create_handle)
> +		ret = fb->funcs->create_handle(fb, file_priv, &r->handle);
> +	else
> +		ret = -ENODEV;

Should this perhaps be -ENOSYS?

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130118/8c533d1b/attachment.pgp>


More information about the dri-devel mailing list