[PATCH] drm: Remove the error message following mmap_offset allocation failures

Chris Wilson chris at chris-wilson.co.uk
Tue Jan 22 06:26:40 PST 2013


As we propagate the error back to our caller, who may act intelligently
upon that error, we should refrain from shouting out that there has been
an *ERROR* prematurely.

Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
---
 drivers/gpu/drm/drm_gem.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index 24efae4..88c6662 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -357,7 +357,6 @@ drm_gem_create_mmap_offset(struct drm_gem_object *obj)
 			obj->size / PAGE_SIZE, 0, false);
 
 	if (!list->file_offset_node) {
-		DRM_ERROR("failed to allocate offset for bo %d\n", obj->name);
 		ret = -ENOSPC;
 		goto out_free_list;
 	}
@@ -371,10 +370,8 @@ drm_gem_create_mmap_offset(struct drm_gem_object *obj)
 
 	list->hash.key = list->file_offset_node->start;
 	ret = drm_ht_insert_item(&mm->offset_hash, &list->hash);
-	if (ret) {
-		DRM_ERROR("failed to add to map hash\n");
+	if (ret)
 		goto out_free_mm;
-	}
 
 	return 0;
 
-- 
1.7.10.4



More information about the dri-devel mailing list