[PATCH 06/16] drm/fb-helper: inline drm_fb_helper_single_add_all_connectors

[Daniel Vetter]

On Thu, Jan 24, 2013 at 10:27 PM, Dave Airlie <airlied at gmail.com> wrote:
> On Fri, Jan 25, 2013 at 2:20 AM, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
>> All drivers call this right after drm_fb_helper_init, and the only
>> thing this function does is allocate a bit of memory and set up a
>> bunch of pointers. No reason at all the keep this as a separate step.
>>
> Doesn't this stop future drivers from only adding a subset of outputs
> to the fb layer?

Oh, I kinda didn't come up with the idea that this is something people
actually want ... I've also killed the choice no driver opted for to
be able to resize the fb. Imo the usecase for fbdev is to show boot
messages, for which you don't need more. And oopses, which I'm unsure
whether it's really that good at.

But I'm not terribly attached to this, so can easily take it out again.

> It's kinda funny in patch 9 you give choice to drivers, and in this
> patch you take away a different choice :-)

Well, it's the choice I care about for drm/i915. I admit, I'm biased ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch