[PATCH V3] drm_crtc: check if fb_create return NULL

Su, Xuemin xuemin.su at intel.com
Wed Jan 30 16:55:21 PST 2013



-----Original Message-----
From: Jani Nikula [mailto:jani.nikula at linux.intel.com] 
Sent: Thursday, January 24, 2013 5:05 PM
To: Su, Xuemin
Cc: airlied at linux.ie; dri-devel at lists.freedesktop.org; linux-kernel at vger.kernel.org; yanmin_zhang at linux.intel.com; He, Bo
Subject: Re: [PATCH V3] drm_crtc: check if fb_create return NULL

>Ah, sorry, never mind, I missed Daniel's comment. The benefit of the
>BUG_ON() is making it clear what's expected of the drivers.

>Reviewed-by: Jani Nikula <jani.nikula at intel.com>

Do you think this patch is still needed?
Currently I fix a buggy function radeon_user_framebuffer_create() which returns NULL and patch is added to 3.7-stable tree.
Do you think it's also needed to do something in drm_mode_addfb()?
Thanks.


More information about the dri-devel mailing list