[PATCH] drm/radeon: Calling object_unrefer() when creating fb failure

[Alex Deucher]

On Thu, Jan 31, 2013 at 12:59 AM, Su, Xuemin <xuemin.su at intel.com> wrote:
> From: liu chuansheng <chuansheng.liu at intel.com>
> Date: Thu, 31 Jan 2013 22:13:00 +0800
> Subject: [PATCH] drm/radeon: Calling object_unrefer() when creating fb
>  failure
>
> When kzalloc() failed in radeon_user_framebuffer_create(), need to
> call object_unreference() to match the object_reference().
>
> Signed-off-by: liu chuansheng <chuansheng.liu at intel.com>
> Signed-off-by: xueminsu <xuemin.su at intel.com>

Thanks.  I've picked this up.

Alex

> ---
>  drivers/gpu/drm/radeon/radeon_display.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> index ff3def7..05c96fa 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -1115,8 +1115,10 @@ radeon_user_framebuffer_create(struct drm_device *dev,
>         }
>
>         radeon_fb = kzalloc(sizeof(*radeon_fb), GFP_KERNEL);
> -       if (radeon_fb == NULL)
> +       if (radeon_fb == NULL) {
> +               drm_gem_object_unreference_unlocked(obj);
>                 return ERR_PTR(-ENOMEM);
> +       }
>
>         ret = radeon_framebuffer_init(dev, radeon_fb, mode_cmd, obj);
>         if (ret) {
> --
> 1.7.6
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel