[PATCH v2 3/3] drm: fix error routines in drm_open_helper

Chris Wilson chris at chris-wilson.co.uk
Mon Jul 1 03:57:05 PDT 2013


On Mon, Jul 01, 2013 at 07:49:10PM +0900, Seung-Woo Kim wrote:
> +
> +out_close:
> +	if (dev->driver->postclose)
> +		dev->driver->postclose(dev, priv);
> +out_free:
>  	kfree(priv);
>  	filp->private_data = NULL;
>  	return ret;

Looks like we are also missing:

if (drm_core_check_feature(dev, DRIVER_PRIME))
	drm_prime_destroy_file_private(&file_priv->prime);

put_pid(file_priv->pid);

after out_free.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the dri-devel mailing list