[PATCH 2/2] drm/i915: use drm_mm_remove_node instead of put_block

Chris Wilson chris at chris-wilson.co.uk
Mon Jul 1 13:16:56 PDT 2013


On Mon, Jul 01, 2013 at 10:05:54PM +0200, Daniel Vetter wrote:
> When converting to the preallocated drm_mm_node interfaces in
> 
> commit dc9dd7a20fde95aa81a8307cde79c2dff9f83f3d
> Author: Chris Wilson <chris at chris-wilson.co.uk>
> Date:   Fri Dec 7 20:37:07 2012 +0000
> 
>     drm/i915: Preallocate the drm_mm_node prior to manipulating the GTT drm_mm
> 
> only the allocation side was converted, but not the freeing. Fix this
> up.
> 
> Note that the only difference between put_block and remove_node is
> that the former fills up the preallocation cache. Which we don't need
> anyway and hence is just wasted space.
> 
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Ben Widawsky <ben at bwidawsk.net>
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

You learn something new every day.
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the dri-devel mailing list