[PATCH 2/3] drm/edid: Fix uninitialized return variable in edid_load()

Geert Uytterhoeven geert at linux-m68k.org
Wed Jul 10 04:16:35 PDT 2013


drivers/gpu/drm/drm_edid_load.c: In function ‘edid_load’:
drivers/gpu/drm/drm_edid_load.c:141: warning: ‘edid’ may be used uninitialized
in this function

In some error cases, edid_load() will return the uninitialized variable.
Initialize it to NULL to fix this.

Signed-off-by: Geert Uytterhoeven <geert at linux-m68k.org>
---
 drivers/gpu/drm/drm_edid_load.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_edid_load.c b/drivers/gpu/drm/drm_edid_load.c
index 2c2803f..9be3467 100644
--- a/drivers/gpu/drm/drm_edid_load.c
+++ b/drivers/gpu/drm/drm_edid_load.c
@@ -138,7 +138,7 @@ static u8 *edid_load(struct drm_connector *connector, char *name,
 {
 	const struct firmware *fw;
 	struct platform_device *pdev;
-	u8 *fwdata = NULL, *edid, *new_edid;
+	u8 *fwdata = NULL, *edid = NULL, *new_edid;
 	int fwsize, expected;
 	int builtin = 0, err = 0;
 	int i, valid_extensions = 0;
-- 
1.7.9.5



More information about the dri-devel mailing list