Bug in warning message from MTRR rework in uvesafb
Daniel Vetter
daniel at ffwll.ch
Wed Jul 10 10:51:09 PDT 2013
On Wed, Jul 10, 2013 at 7:07 PM, Torsten Kaiser
<just.for.lkml at googlemail.com> wrote:
> Commit 63e28a7a5ffce59b645ca9cbcc01e1e8be56bd75, "uvesafb: Clean up
> MTRR code" contains the following change:
>
> @@ -1930,6 +1891,9 @@ static int uvesafb_setup(char *options)
> }
> }
>
> + if (mtrr != 3 && mtrr != 1)
> + pr_warn("uvesafb: mtrr should be set to 0 or 3; %d is
> unsupported", mtrr);
> +
> return 0;
> }
> #endif /* !MODULE */
>
> Shouldn't this be && mtrr != 0?
Yes, you're right, I've failed to spot that while reviewing. Can you
please submit a proper kernel patch, see
Documentation/SubmittingPatches?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
More information about the dri-devel
mailing list