[PATCH 1/3] drm/radeon: Disable dma rings for bo moves on r6xx

Christian König deathsimple at vodafone.de
Thu Jul 11 23:50:49 PDT 2013


Am 11.07.2013 21:35, schrieb alexdeucher at gmail.com:
> From: Alex Deucher <alexander.deucher at amd.com>
>
> They still seem to cause instability on some r6xx parts.
> As a follow up, we can switch to using CP DMA for bo
> moves on r6xx as a lighter weight alternative to using
> the 3D engine.
>
> A version of this patch should also go to stable kernels.
>
> Tested-by: J.N. <golden.fleeced at gmail.com>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>

Well since we have an easy to use alternative, isn't it time to kill off 
all the blitter code?

Anyway this patch series is:

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/radeon/radeon_asic.c |   12 ++++++------
>   1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_asic.c b/drivers/gpu/drm/radeon/radeon_asic.c
> index 0970774..ea5c52b 100644
> --- a/drivers/gpu/drm/radeon/radeon_asic.c
> +++ b/drivers/gpu/drm/radeon/radeon_asic.c
> @@ -1026,8 +1026,8 @@ static struct radeon_asic r600_asic = {
>   		.blit_ring_index = RADEON_RING_TYPE_GFX_INDEX,
>   		.dma = &r600_copy_dma,
>   		.dma_ring_index = R600_RING_TYPE_DMA_INDEX,
> -		.copy = &r600_copy_dma,
> -		.copy_ring_index = R600_RING_TYPE_DMA_INDEX,
> +		.copy = &r600_copy_blit,
> +		.copy_ring_index = RADEON_RING_TYPE_GFX_INDEX,
>   	},
>   	.surface = {
>   		.set_reg = r600_set_surface_reg,
> @@ -1119,8 +1119,8 @@ static struct radeon_asic rv6xx_asic = {
>   		.blit_ring_index = RADEON_RING_TYPE_GFX_INDEX,
>   		.dma = &r600_copy_dma,
>   		.dma_ring_index = R600_RING_TYPE_DMA_INDEX,
> -		.copy = &r600_copy_dma,
> -		.copy_ring_index = R600_RING_TYPE_DMA_INDEX,
> +		.copy = &r600_copy_blit,
> +		.copy_ring_index = RADEON_RING_TYPE_GFX_INDEX,
>   	},
>   	.surface = {
>   		.set_reg = r600_set_surface_reg,
> @@ -1229,8 +1229,8 @@ static struct radeon_asic rs780_asic = {
>   		.blit_ring_index = RADEON_RING_TYPE_GFX_INDEX,
>   		.dma = &r600_copy_dma,
>   		.dma_ring_index = R600_RING_TYPE_DMA_INDEX,
> -		.copy = &r600_copy_dma,
> -		.copy_ring_index = R600_RING_TYPE_DMA_INDEX,
> +		.copy = &r600_copy_blit,
> +		.copy_ring_index = RADEON_RING_TYPE_GFX_INDEX,
>   	},
>   	.surface = {
>   		.set_reg = r600_set_surface_reg,



More information about the dri-devel mailing list