[PATCH 04/16] drm/mgag200: Don't unreference when handle creation failed

Egbert Eich eich at suse.com
Wed Jul 17 08:55:22 PDT 2013


Chris Wilson writes:
 > On Wed, Jul 17, 2013 at 03:07:17PM +0200, Egbert Eich wrote:
 > > drm_gem_handle_create() should not have referenced an object when it's
 > > creation has failed for some reason.
 > > 
 > > Signed-off-by: Egbert Eich <eich at suse.com>
 > 
 > Nak. The unreference here is to free the locally created resource before
 > returning the error to the user. In the case of success, the only
 > reference to the object that then remains is through the new handle.
 > -Chris

Argh, yeah, you're right. Sorry.

Cheers,
	Egbert.


More information about the dri-devel mailing list