[PATCH] drm/mgag200: Don't do full cleanup if mgag200_device_init fails

Paul Menzel paulepanter at users.sourceforge.net
Wed Jun 12 14:16:13 PDT 2013


Dear Christopher,


Am Mittwoch, den 05.06.2013, 11:29 -0400 schrieb Christopher Harvey:
> Running mgag200_driver_unload when the driver init fails early on
> causes functions like drm_mode_config_cleanup to be called. The
> problem is, drm_mode_config_cleanup crashes because the corresponding
> init hasn't happend yet. There really isn't anything to cleanup after
> mgag200_device_init, so we can just pass the error code upwards.
> 
> Acked-by: Julia Lemire <jlemire at matrox.com>
> Signed-off-by: Christopher Harvey <charvey at matrox.com>
> ---
>  drivers/gpu/drm/mgag200/mgag200_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

[…]

Acked-by: Paul Menzel <paulepanter at users.sourceforge.net>


You should always CC the maintainer when sending in patches.


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130612/4ffa12a5/attachment.pgp>


More information about the dri-devel mailing list