[PATCH V2 7/7] drm/tilcdc: Clear bits of register we're going to set.

Darren Etheridge detheridge at ti.com
Fri Jun 21 11:52:28 PDT 2013


From: Pantelis Antoniou <panto at antoniou-consulting.com>

Bits weren't cleared so resolution changes didn't work.

Signed-off-by: Pantelis Antoniou <panto at antoniou-consulting.com>
Signed-off-by: Darren Etheridge <detheridge at ti.com>
---
 drivers/gpu/drm/tilcdc/tilcdc_crtc.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
index 6118651..eb06f70 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
@@ -299,6 +299,8 @@ static int tilcdc_crtc_mode_set(struct drm_crtc *crtc,
 	 * a value of 0 as 1
 	 */
 	if (priv->rev == 2) {
+		/* clear bits we're going to set */
+		reg &= ~0x78000033;
 		reg |= ((hfp-1) & 0x300) >> 8;
 		reg |= ((hbp-1) & 0x300) >> 4;
 		reg |= ((hsw-1) & 0x3c0) << 21;
-- 
1.7.0.4



More information about the dri-devel mailing list