[PATCH 1/5] videomode: simplify videomode Kconfig and Makefile
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Tue Mar 12 06:34:07 PDT 2013
Hi Tomi,
Thanks for the patch.
On Tuesday 12 March 2013 12:19:34 Tomi Valkeinen wrote:
> This patch simplifies videomode related Kconfig and Makefile. After this
> patch, there's only one non-user selectable Kconfig option left,
> VIDEOMODE_HELPERS. The reasons for the change:
>
> * Videomode helper functions are not something that should be shown in
> the kernel configuration options. The related code should just be
> included if it's needed, i.e. selected by drivers using videomode.
>
> * There's no need to have separate Kconfig options for videomode and
> display_timing. First of all, the amount of code for both is quite
> small. Second, videomode depends on display_timing, and display_timing
> in itself is not really useful, so both would be included in any case.
>
> * CONFIG_VIDEOMODE is a bit vague name, and CONFIG_VIDEOMODE_HELPERS
> describes better what's included.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ti.com>
> Cc: Steffen Trumtrar <s.trumtrar at pengutronix.de>
I like that.
Acked-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
--
Regards,
Laurent Pinchart
More information about the dri-devel
mailing list