[PATCH 5/5] videomode: rename fields

[Tomi Valkeinen]

Hi,

On 2013-03-12 15:37, Laurent Pinchart wrote:
> Hi Tomi,
> 
> Thanks for the patch.
> 
> On Tuesday 12 March 2013 12:19:38 Tomi Valkeinen wrote:
>> Structs videomode and display_timing have rather long field names for
>> the timing values. Nothing wrong with that as such, but this patch
>> changes them to abbreviations for the following reasons:
>>
>> * The timing values often need to be used in calculations, and long
>>   field names makes their direct use clumsier.
>>
>> * The current names are a bit of a mishmash: some words are used as
>>   such, some are shortened, and for some only first letter is used. Some
>>   names use underscode, some don't. All this makes it difficult to
>>   remember what the field names are.
>>
>> * The abbreviations used in this patch are very common, and there
>>   shouldn't be any misunderstanding about their meaning.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ti.com>
>> Cc: Steffen Trumtrar <s.trumtrar at pengutronix.de>
>> ---
> 
> I have no strong opinion on this, but I find the existing names easier to 
> read. I might be biased by having read them often though.

Yes, the last patch was a bit of a "teaser" =). I found myself typoing
them a lot, using helper local variables to shorten the code lines, and
as I mention in the description, I find them a bit of a mishmash. So,
while they're not used in any drivers yet, I thought it'd be worth a
shot to change them.

 Tomi


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 899 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130312/408ec53e/attachment-0001.pgp>