[PATCH v3] drm/i915: bounds check execbuffer relocation count
Daniel Vetter
daniel at ffwll.ch
Wed Mar 13 13:28:58 PDT 2013
On Tue, Mar 12, 2013 at 09:07:46AM +0000, Chris Wilson wrote:
> On Mon, Mar 11, 2013 at 05:31:45PM -0700, Kees Cook wrote:
> > It is possible to wrap the counter used to allocate the buffer for
> > relocation copies. This could lead to heap writing overflows.
> >
> > CVE-2013-0913
> >
> > v3: collapse test, improve comment
> > v2: move check into validate_exec_list
> >
> > Signed-off-by: Kees Cook <keescook at chromium.org>
> > Reported-by: Pinkie Pie
> > Cc: stable at vger.kernel.org
>
> Looks good to me. The only bikeshed that remains is whether we should
> just collapse the two variables into one, but the current 'max - count'
> is more idiomatic and so preferrable.
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
Picked up for -fixes, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
More information about the dri-devel
mailing list