[PATCH 2/2] drm/radeon/benchmark: allow same domains for dma copy

Paul Menzel paulepanter at users.sourceforge.net
Thu Mar 14 06:07:54 PDT 2013


Dear Alex,


Am Mittwoch, den 13.03.2013, 12:38 -0400 schrieb alexdeucher at gmail.com:
> From: Alex Deucher <alexander.deucher at amd.com>
> 
> Remove old comment and allow benchmarking moves within the
> same memory domain for both dma and blit methods.
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>  drivers/gpu/drm/radeon/radeon_benchmark.c |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_benchmark.c b/drivers/gpu/drm/radeon/radeon_benchmark.c
> index a2f0c24..6e05a2e 100644
> --- a/drivers/gpu/drm/radeon/radeon_benchmark.c
> +++ b/drivers/gpu/drm/radeon/radeon_benchmark.c
> @@ -122,10 +122,7 @@ static void radeon_benchmark_move(struct radeon_device *rdev, unsigned size,
>  		goto out_cleanup;
>  	}
>  
> -	/* r100 doesn't have dma engine so skip the test */
> -	/* also, VRAM-to-VRAM test doesn't make much sense for DMA */
> -	/* skip it as well if domains are the same */
> -	if ((rdev->asic->copy.dma) && (sdomain != ddomain)) {
> +	if (rdev->asic->copy.dma) {

why is the comment not valid anymore? What changed?

>  		time = radeon_benchmark_do_move(rdev, size, saddr, daddr,
>  						RADEON_BENCHMARK_COPY_DMA, n);
>  		if (time < 0)


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130314/70734f72/attachment.pgp>


More information about the dri-devel mailing list