[PATCH] drm/gma500: fix backlight hotkeys behaviour on cedarview netbooks
Patrik Jakobsson
patrik.r.jakobsson at gmail.com
Thu May 2 05:50:05 PDT 2013
On Thu, May 2, 2013 at 2:39 PM, Anisse Astier <anisse at astier.eu> wrote:
> On Wed, 24 Apr 2013 23:39:58 +0200, Patrik Jakobsson <patrik.r.jakobsson at gmail.com> wrote :
>
>> On Wed, Apr 24, 2013 at 5:36 PM, Anisse Astier <anisse at astier.eu> wrote:
>> > Backlight hotkeys weren't working before on certain cedartrail laptops.
>> >
>> > The source of this problem is that the hotkeys' ASLE opregion interrupts
>> > were simply ignored. Driver seemed to expect the interrupt to be
>> > associated with a pipe, but it wasn't.
>> >
>> > Accepting the ASLE interrupt without an associated pipe event flag fixes
>> > the issue, the backlight code is called when needed, making the
>> > brightness keys work properly.
>> >
> [...]
>>
>> This also fixes backlight keys on my Asus poulsbo laptop.
>>
>> An ASLE IRQ is triggered by the BIOS when writing to a PCI config register. Some
>> BIOSes might trigger a pipe event at the same time but they obviously don't have
>> to (and I don't think they should). I'm not sure it needs to be in
>> psb_vdc_interrupt() but we might as well leave it there for now.
>>
>> I'll apply this to git://github.com/patjak/drm-gma500 gma500-fixes
>>
>> Thanks
>> Patrik
>
> Hi Patrik,
>
> When do you think you'll apply it to your repo ?
>
> Dave, do you think this could go in 3.10 ?
Hi, this is already in my gma500-fixes branch and also in Dave's drm-next for
inclusion in 3.10.
Thanks
Patrik
More information about the dri-devel
mailing list