[PATCH] drm: refactor call to request_module

Paul Menzel paulepanter at users.sourceforge.net
Wed May 8 00:22:41 PDT 2013


Am Dienstag, den 07.05.2013, 12:32 -0700 schrieb Kees Cook:
> This reduces the size of the stack frame when calling request_module().
> Performing the sprintf before the call is not needed.

Good fine. Do you have any hard numbers for the record?

Did you find this just by reading the code or are there any problems
with stack sizes on some systems?

(This patch would be good alone for decreasing the number of code
lines. ;-))

> Signed-off-by: Kees Cook <keescook at chromium.org>
> ---
>  drivers/gpu/drm/drm_encoder_slave.c |    6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

Acked-by: Paul Menzel <paulepanter at users.sourceforge.net>


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130508/5b189bcb/attachment.pgp>


More information about the dri-devel mailing list