[PATCH v3 6/9] radeon: Switch to arch_phys_wc_add and add a missing ..._del

Andy Lutomirski luto at amacapital.net
Wed May 15 11:22:20 PDT 2013


On Wed, May 15, 2013 at 7:49 AM, Jerome Glisse <j.glisse at gmail.com> wrote:
> On Tue, May 14, 2013 at 5:35 PM, Andy Lutomirski <luto at amacapital.net> wrote:
>> On Tue, May 14, 2013 at 6:37 AM, Jerome Glisse <j.glisse at gmail.com> wrote:
>>> On Tue, May 14, 2013 at 8:58 AM, Alex Deucher <alexdeucher at gmail.com> wrote:
>>>> On Mon, May 13, 2013 at 7:58 PM, Andy Lutomirski <luto at amacapital.net> wrote:
>>>>> Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
>>>>> Signed-off-by: Andy Lutomirski <luto at amacapital.net>
>>>>
>>>> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
>>>
>>> I believe it will break something but we could deal with the fallout
>>> once it happens.
>>
>> FWIW, I'm running with this code on my machine right now using the
>> radeon driver.  Everything seems fine.  If I build without MTRRs and
>> without PAT, though, graphics are slow (as expected).  So I think
>> everything's okay.
>>
>> --Andy
>
> I am worried on p4 where i last see issue with that notably with agp.

Do you remember any details?  It looks like PAT is enabled on Pentium
4 (i.e. famliy 0xF).

--Andy


More information about the dri-devel mailing list