[Bug 58521] New: Radeon ATOM BIOS have wrong value in controller->ucType for RV635

[bugzilla-daemon at bugzilla.kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=58521

           Summary: Radeon ATOM BIOS have wrong value in
                    controller->ucType for RV635
           Product: Drivers
           Version: 2.5
    Kernel Version: 3.5.0
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Video(DRI - non Intel)
        AssignedTo: drivers_video-dri at kernel-bugs.osdl.org
        ReportedBy: guram.savinov at gmail.com
        Regression: No


I have Asus M50Sa laptop with ATI Radeon Mobility HD3650(RV635 chip) graphics.
RV635 chip have internal thermal sensor, but for my graphics it's no hwmon
entry in /sys/class/hwmon.

I found that in radeon_atombios.c it's checking for thermal sensor from ATOM
BIOS structure:

##################################
static void radeon_atombios_add_pplib_thermal_controller(struct radeon_device
*rdev,
                                                        
ATOM_PPLIB_THERMALCONTROLLER *controller)
{
        struct radeon_i2c_bus_rec i2c_bus;

        /* add the i2c bus for thermal/fan chip */
        if (controller->ucType > 0) {
                if (controller->ucType == ATOM_PP_THERMALCONTROLLER_RV6xx) {
                        DRM_INFO("Internal thermal controller %s fan
control\n",
                                 (controller->ucFanParameters &
                                  ATOM_PP_FANPARAMETERS_NOFAN) ? "without" :
"with");
                        rdev->pm.int_thermal_type = THERMAL_TYPE_RV6XX;
                } else if (controller->ucType ==
ATOM_PP_THERMALCONTROLLER_RV770) {

...
###################################

But for my graphics controller->ucType have 0, that mean 
ATOM_PP_THERMALCONTROLLER_NONE.
I try to set THERMAL_TYPE_RV6XX to controller->ucType, hwmon was added and I
have thermal sensor for my RV635 chip, all works great.

May be it's Asus M50Sa ATOM BIOS bug, but why you check thermal sensor for
RV635?
Is it possible to have RV635 chip without internal thermal sensor?

It'll be great to not check thermal sensor type for RV635 chip, because AMD say
that it shipped with internal thermal sensor.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.