[PATCH v3 04/32] drm/exynos: Use manager_op initialize in fimd

[Tomasz Figa]

Hi Sean,

On Tuesday 29 of October 2013 12:12:50 Sean Paul wrote:
> This patch implements the intitialize manager op in fimd.
> 
> Signed-off-by: Sean Paul <seanpaul at chromium.org>
> ---
> 
> Changes in v2: None
> Changes in v3: None
> 
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c | 19 +++++++++++++++----
>  1 file changed, 15 insertions(+), 4 deletions(-)
[snip]
>  static void fimd_dpms(struct device *subdrv_dev, int mode)
>  {
>  	struct fimd_context *ctx = get_fimd_context(subdrv_dev);
> @@ -660,6 +671,7 @@ static void fimd_wait_for_vblank(struct device *dev)
> }
> 
>  static struct exynos_drm_manager_ops fimd_manager_ops = {
> +	.initialize = fimd_mgr_initialize,
>  	.dpms = fimd_dpms,
>  	.apply = fimd_apply,
>  	.commit = fimd_commit,
> @@ -681,7 +693,6 @@ static irqreturn_t fimd_irq_handler(int irq, void
> *dev_id) {
>  	struct fimd_context *ctx = (struct fimd_context *)dev_id;
>  	struct exynos_drm_subdrv *subdrv = &ctx->subdrv;
> -	struct drm_device *drm_dev = subdrv->drm_dev;

Apparently the driver already can have a reference to drm_device, without 
the .initialize() method being called.

I guess your change makes it somehow better, but patch description fails 
to explain this.

Best regards,
Tomasz