[PATCH 01/19] drm/rcar: call drm_put_dev directly in the ->remove hook
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Sun Nov 3 05:47:49 PST 2013
Hi Daniel,
Thank you for the patch.
On Sunday 03 November 2013 14:31:07 Daniel Vetter wrote:
> The magic dance drm_platform_exit does is actually a remnant of the
> old legacy shadow attach support for platform devices. Modern modesetting
> drm drivers shouldn't do this any more (and usb/pci devices actually don't
> do this).
>
> Cc: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
For 01/19 and 06/19,
Acked-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 0023f9719cf1..4ec6272a1c11
> 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -224,7 +224,9 @@ static int rcar_du_probe(struct platform_device *pdev)
>
> static int rcar_du_remove(struct platform_device *pdev)
> {
> - drm_platform_exit(&rcar_du_driver, pdev);
> + struct rcar_du_device *rcdu = platform_get_drvdata(pdev);
> +
> + drm_put_dev(rcdu->ddev);
>
> return 0;
> }
--
Regards,
Laurent Pinchart
More information about the dri-devel
mailing list