[PATCH 7/8] dri: add __DRIimageLoaderExtension and __DRIimageDriverExtension

Kristian Høgsberg hoegsberg at gmail.com
Tue Nov 5 18:48:41 PST 2013


On Tue, Nov 5, 2013 at 4:59 PM, Keith Packard <keithp at keithp.com> wrote:
> Kristian Høgsberg <hoegsberg at gmail.com> writes:
>
>
>> We can drop width and height now and just get it from either of the
>> returned images.  Format is a function of the __DRIconfig and doesn't
>> change, so we could make that something you can query from the config
>> in the interest of further reducing the number of arguments.
>
> Sure would be nice if there were simpler ways than calling the
> getAttribs function though; I'm tempted to just leave these params in as
> every single driver will need those values and passing them back here
> will make the driver code shorter.

I would say that it's more important to keep the interfaces between
components as simple as possible, even if it incurs a little
inconvenience inside the driver.

But it's a non-issue, since inside the driver you can just access them
as image->width/height.

>> I'll give this a try with the GBM and Wayland EGL backends now.
>
> Cool. Having two backends using this same interface would really help
> out.

I got this running now and I found a few other things.  I'll reply to
the patch again.

Kristian


More information about the dri-devel mailing list