i915: pipe state still does not match

[Chris Wilson]

On Thu, Nov 28, 2013 at 09:08:45PM +0100, Jan Engelhardt wrote:
> On Wednesday 2013-11-27 12:08, Chris Wilson wrote:
> >On Wed, Nov 27, 2013 at 11:59:56AM +0100, Jan Engelhardt wrote:
> >> 
> >> Despite the i915/drm fixes added in v3.11.8, the X server still 
> >> terminates due to some pipe state bug in 3.11.9.
> >
> >X terminating is entirely unconnected with that *ERROR*.
> 
> Are you sure? Whenever X crashed, that inteldrv kernel message
> was showing up in dmesg.
> Affected versions:
> 	xorg-x11-server-1.14.3.901
> 	xf86-video-intel-2.99.906-4.1.x86_64
> Working versions:
> 	xorg-x11-server-1.13.2
> 	xf86-video-intel-2.20.19
> 
> >Can you please attach your Xorg.0.log with the crash information?
> 
> What I could collect so far:

Thanks, I broke the handling of cropped XvImages along the fast paths.
It should be fixed by:

commit fd007d9d465b9b3ddbbaf769931ec921a6f5ecb8
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Thu Nov 28 21:13:33 2013 +0000

    sna/video: Correct handling of cropped images along packed fast path
    
    In particular, it was offseting the read from the source image, but not
    correcting the length to read - causing a read from beyond the end of
    the source and a segfault.
    
    Reported-by: Jan Engelhardt <jengelh at inai.de>
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre