[PATCH v3 28/32] drm/exynos: Implement drm_connector in hdmi directly

[Tomasz Figa]

Hi Sean,

On Tuesday 29 of October 2013 12:13:14 Sean Paul wrote:
> This patch implements drm_connector in the hdmi driver directly, instead
> of using exynos_drm_connector.
> 
> Signed-off-by: Sean Paul <seanpaul at chromium.org>
> ---
> 
> Changes in v3:
> 	- Added to the patchset
> 
>  drivers/gpu/drm/exynos/exynos_hdmi.c | 126 +++++++++++++++++++++++------------
>  1 file changed, 85 insertions(+), 41 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index c6561fe..b063610 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -43,9 +43,8 @@
>  #include <linux/gpio.h>
>  #include <media/s5p_hdmi.h>
>  
> -#define MAX_WIDTH		1920
> -#define MAX_HEIGHT		1080

Hmm, you are removing these values, but they don't seem to be redefined
in any way anywhere below. Are you removing some of the video mode checks?

>  #define get_hdmi_display(dev)	platform_get_drvdata(to_platform_device(dev))
> +#define ctx_from_connector(c)	container_of(c, struct hdmi_context, connector)
>  
>  /* AVI header and aspect ratio */
>  #define HDMI_AVI_VERSION		0x02
[snip]
> @@ -811,11 +816,60 @@ static int hdmi_check_mode(struct exynos_drm_display *display,
>  
>  	ret = mixer_check_mode(mode);
>  	if (ret)
> -		return ret;
> +		return MODE_BAD;

Is there a need to define custom return values, instead of returning 0 or
a standard error code depending on whether the mode is correct?

Best regards,
Tomasz