[PATCH v2 06/27] gpu: host1x: Cleanup includes

Terje Bergström tbergstrom at nvidia.com
Tue Oct 8 07:59:58 CEST 2013


On 07.10.2013 11:34, Thierry Reding wrote:
> Most of the included files are either not required or already included
> by some other header file.

What's the general policy? I personally feel that each source file
should #include all the header files it needs, and should not rely on
header files #including other header files.

This way if header file A stops needing header file B, we don't need to
go and fix all users of header file A that assume B is included.

I've been hit by this multiple times in Linux kernel - sometimes some
header files just assume another header file is #included and refuses to
compile it it isn't.

Terje


More information about the dri-devel mailing list