[PATCH] drm/nouveau: suspend to D3hot, not to D3cold

Maarten Lankhorst maarten.lankhorst at canonical.com
Tue Oct 8 17:36:38 CEST 2013


In the autumn and winter it's considered bad form to set power state to D3cold, it might
cause the device to freeze to death. This is also the case in the other seasons, so any
device in the southern hemisphere is affected too.

D3cold is not a valid state in a call to pci_set_power_state, only up to D3hot is allowed.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst at canonical.com>
---
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
index 89efeff..566e544 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
@@ -945,7 +945,7 @@ static int nouveau_pmops_runtime_suspend(struct device *dev)
 	ret = nouveau_do_suspend(drm_dev);
 	pci_save_state(pdev);
 	pci_disable_device(pdev);
-	pci_set_power_state(pdev, PCI_D3cold);
+	pci_set_power_state(pdev, PCI_D3hot);
 	drm_dev->switch_power_state = DRM_SWITCH_POWER_DYNAMIC_OFF;
 	return ret;
 }



More information about the dri-devel mailing list