[PATCH] drm: allocate crtc mutex separately from crtc

Ilija Hadzic ilijahadzic at gmail.com
Fri Oct 18 03:27:41 CEST 2013


(dropping stable at ... until we get the fix we can agree on)

While looking through that function (drm_crtc_helper_set_config) to
figure out what we really need to save and restore, I came across a
piece of code that you added in 25f397a4. The 'if (connector->dpms !=
DRM_MODE_DPMS_ON)'  (line 719 in the version that is on the top of
Dave's drm-next branch), comes right after the unconditional break, is
unreachable code (and removing it produces the same object code). Can
you explain what your intent was here? Also, the comment above the
break that reads "don't break so fail path works correct[sic]" doesn't
make much sense to me either.

-- Ilija


More information about the dri-devel mailing list