[PATCH 1/5] drm/i2c: tda998x: set VIF for full range, underscanned display

[Rob Clark]

On Mon, Oct 7, 2013 at 4:59 AM, Jean-Francois Moine <moinejf at free.fr> wrote:
> On Sun, 06 Oct 2013 23:07:55 +0100
> Russell King <rmk+kernel at arm.linux.org.uk> wrote:
>
>> Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>
>> ---
>>  drivers/gpu/drm/i2c/tda998x_drv.c |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
>> index 60e8404..704040b5 100644
>> --- a/drivers/gpu/drm/i2c/tda998x_drv.c
>> +++ b/drivers/gpu/drm/i2c/tda998x_drv.c
>> @@ -549,6 +549,8 @@ tda998x_write_avi(struct drm_encoder *encoder, struct drm_display_mode *mode)
>>       buf[HB(0)] = 0x82;
>>       buf[HB(1)] = 0x02;
>>       buf[HB(2)] = 13;
>> +     buf[PB(1)] = 2; /* underscanned display */
>> +     buf[PB(3)] = 2 << 2; /* full range */
>>       buf[PB(4)] = drm_match_cea_mode(mode);
>>
>>       tda998x_write_if(encoder, DIP_IF_FLAGS_IF2, REG_IF2_HB0, buf,
>
> You should use the 'hdmi.h' constants which are meaningful enough:
>
>         buf[PB(1)] = HDMI_SCAN_MODE_UNDERSCAN;
>         buf[PB(3)] = HDMI_QUANTIZATION_RANGE_FULL << 2;
>

with the update to use hdmi.h const, this has my

Reviewed-by: Rob Clark <robdclark at gmail.com>

(and other ones I replied last night, s/s-o-b/r-b/)

> --
> Ken ar c'hentañ |             ** Breizh ha Linux atav! **
> Jef             |               http://moinejf.free.fr/