drm/exynos: change callback argument of sub driver with device

Olof Johansson olof at lixom.net
Mon Oct 28 17:38:42 CET 2013


On Mon, Oct 28, 2013 at 6:35 AM, Inki Dae <inki.dae at samsung.com> wrote:
> This patch makes callback funtions of each sub driver to be called
> with device object instead of display and manager.
>
> Exynos drm framework doesn't need to pass a manager or a display
> when calling callback function of each sub driver, and each sub
> driver can get its own context from device object. So this patch
> hides sub driver's context from framework.

This is a step backwards. There should be no need to have every driver
have a full struct device associated with it, so removing the
requirement to have a struct device is the right thing to do (and this
patch undoes that).

Sticking to the strict driver model on all display IP on SoCs is
making things overly complicated. Sean is clearly moving the Exynos
DRM in the right direction with his restructuring, so please don't
undo his work like this. Especially not without cc:ing him on the
patches.


-Olof


More information about the dri-devel mailing list