[PATCH] drm/radeon: don't use PACKET2 on CIK

Alex Deucher alexdeucher at gmail.com
Wed Oct 30 14:52:07 CET 2013


On Wed, Oct 30, 2013 at 9:50 AM, Christian König
<deathsimple at vodafone.de> wrote:
> Am 30.10.2013 14:41, schrieb Marek Olšák:
>
>> From: Marek Olšák <marek.olsak at amd.com>
>>
>> It is said to cause hangs.
>>
>> Signed-off-by: Marek Olšák <marek.olsak at amd.com>
>
>
> We should probably do so for SI as well.
>

SI doesn't support single DW type 3 nop packets and AFAIK, there are
no bugs with type 2 packet handling on SI.

Alex

> Patch is Reviewed-by: Christian König <christian.koenig at amd.com>
>
>
>> ---
>>   drivers/gpu/drm/radeon/cik.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c
>> index 2cd2ac0..44507a4 100644
>> --- a/drivers/gpu/drm/radeon/cik.c
>> +++ b/drivers/gpu/drm/radeon/cik.c
>> @@ -7134,7 +7134,7 @@ static int cik_startup(struct radeon_device *rdev)
>>         ring = &rdev->ring[RADEON_RING_TYPE_GFX_INDEX];
>>         r = radeon_ring_init(rdev, ring, ring->ring_size,
>> RADEON_WB_CP_RPTR_OFFSET,
>>                              CP_RB0_RPTR, CP_RB0_WPTR,
>> -                            RADEON_CP_PACKET2);
>> +                            PACKET3(PACKET3_NOP, 0x3FFF));
>>         if (r)
>>                 return r;
>>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel


More information about the dri-devel mailing list