[PATCH] drm/tda998x: BUG() on invalid audio format

David Herrmann dh.herrmann at gmail.com
Sun Sep 1 06:23:04 PDT 2013

Suppress warning of unused-variables by adding a BUG()+return for invalid

Cc: Rob Clark <robdclark at gmail.com>
Signed-off-by: David Herrmann <dh.herrmann at gmail.com>
Hey Rob

No idea whether it's correct. But all I know is when we hit the default: path,
several variables will be unset. To avoid gcc warn about it, I added the BUG().
If we should just silently return, feel free to adjust the patch to your needs.


 drivers/gpu/drm/i2c/tda998x_drv.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index c2bd711..b1f8fc6 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -596,6 +596,10 @@ tda998x_configure_audio(struct drm_encoder *encoder,
 		cts_n = CTS_N_M(3) | CTS_N_K(3);
 		ca_i2s = CA_I2S_CA_I2S(0);
+	default:
+		BUG();
+		return;
 	reg_write(encoder, REG_AIP_CLKSEL, clksel_aip);

More information about the dri-devel mailing list